workshopsoft/ludic
2
0
Fork 0
Code Issues Pull requests Projects Releases 26 Packages Wiki Activity Actions

fix(cli): report the installed version, not the current directory's

Browse source 
`ludic version` looked for bin/ludicc and VERSION relative to the working
directory. In the toolchain repo that is right by accident; from a project — the
only place a user runs it — there is no ./bin, so a perfectly good install
answered "(version unknown)". It now resolves the compiler through
ludic_home(), like every other command.

The regression test asked for the version from the repo root, so it passed for
the same accidental reason the bug hid behind; it now asks from the staged
project, where the answer can only come from the install.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Orkun ÇAKILKAYA 2026-09-05 22:16:16 +03:00
parent 2caf74946f
commit 29fcef3b9c
3 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
changes/version-from-install-root.md Normal file
View file

@ -0,0 +1,6 @@
bump: patch
type: fix
`ludic version` reports the version of the toolchain it belongs to. It looked for
`bin/ludicc` and `VERSION` beside the *current* directory, so it answered
"(version unknown)" from a project — which is the only place a user ever runs it.
It now resolves the compiler through the install root, like every other command.

16
tools/ludic-cli/release.ludic
View file

@ -49,13 +49,21 @@ function compute_next(cur: pointer, level: pointer) -> pointer {
return `{maj}.{min}.{p2}` return `{maj}.{min}.{p2}`
} }
# ludic version — report the toolchain version. Prefer the compiler's own --version # ludic version — report the version of the toolchain this CLI belongs to.
# (proving that path works); fall back to the file if ludicc is not built yet. #
# It asks the compiler (proving that path works), addressed through ludic_home()
# rather than as a relative bin/ludicc: `ludic version` is run from a user's
# project, not from the toolchain's own directory, and looking beside the current
# directory found nothing there and reported "(version unknown)" for a perfectly
# good install.
function cmd_version() -> int { function cmd_version() -> int {
if is_exec("bin/ludicc") { let cc = ludicc()
run("LUDIC_HOME=. bin/ludicc --version") if is_exec(cc) {
run(`{cc} --version`)
return 0 return 0
} }
let v = read_file(`{ludic_home()}VERSION`)
if v != null { print(`ludic {s_trim(v)}`); return 0 }
print(`ludic {read_version_or("(version unknown)")}`) print(`ludic {read_version_or("(version unknown)")}`)
return 0 return 0
} }

5
tools/ludic-cli/test.ludic
View file

@ -84,7 +84,10 @@ function install_layout_case() -> void {
if not shq(`cd {work}/demo && {envp} ludic test > {work}/test.out 2>&1`) { if not shq(`cd {work}/demo && {envp} ludic test > {work}/test.out 2>&1`) {
bad2(lbl, capture_line(`tail -1 {work}/test.out`)); return bad2(lbl, capture_line(`tail -1 {work}/test.out`)); return
} }
let ver = capture_line(`{envp} ludic version`) # from the project directory, never the repo root: `ludic version` used to
# answer from a ./bin and ./VERSION next to the *current* directory, which made
# this check pass in the repo while a real install said "(version unknown)".
let ver = capture_line(`cd {work}/demo && {envp} ludic version`)
if ver != `ludic {s_trim(read_file("VERSION"))}` { if ver != `ludic {s_trim(read_file("VERSION"))}` {
bad2("an installed `ludic version` reports the install's VERSION", `got [{ver}]`); return bad2("an installed `ludic version` reports the install's VERSION", `got [{ver}]`); return
} }