compiler: the most negative int is emitted as itself - itoa took its digits off -v, which overflows back to itself, so 0x80000000 in an int was written as a bare "-" (invalid IR); digits now come off v as it is, and the buffer holds a long's 20
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
3d5aaa6f6e
commit
37338cb0f7
3 changed files with 27 additions and 4 deletions
|
|
@ -20,12 +20,19 @@ function str_starts(s: pointer, prefix: pointer) -> bool {
|
|||
# integer -> fresh decimal string
|
||||
function itoa(v: int) -> pointer {
|
||||
if v == 0 { let z = bytes(2); z[0] = '0'; z[1] = 0; return z }
|
||||
var neg = false
|
||||
# digits are taken off v as it is, never off -v: the most negative int has no positive twin, and
|
||||
# -v overflowed back to itself, so a 0x80000000 in an i32 was emitted as a bare "-"
|
||||
let neg = v < 0
|
||||
var x = v
|
||||
if x < 0 { neg = true; x = -x }
|
||||
let tmp = bytes(16)
|
||||
let tmp = bytes(24)
|
||||
var n = 0
|
||||
while x > 0 { tmp[n] = 48 + x % 10; x /= 10; n += 1 }
|
||||
while x != 0 {
|
||||
var d = x % 10
|
||||
if d < 0 { d = -d }
|
||||
tmp[n] = 48 + d
|
||||
x /= 10
|
||||
n += 1
|
||||
}
|
||||
var total = n
|
||||
if neg { total += 1 }
|
||||
let out = bytes(total + 1)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue